From ea1580818155187f1910eaac821f8fd30e210b57 Mon Sep 17 00:00:00 2001
From: Rein Appeldoorn <rein.appeldoorn@nobleo.nl>
Date: Wed, 18 Sep 2024 08:07:00 +0200
Subject: [PATCH] comments Steve

Signed-off-by: Rein Appeldoorn <rein.appeldoorn@nobleo.nl>
---
 nav2_controller/src/controller_server.cpp | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/nav2_controller/src/controller_server.cpp b/nav2_controller/src/controller_server.cpp
index 74b3f3707b..ec9dc3d81b 100644
--- a/nav2_controller/src/controller_server.cpp
+++ b/nav2_controller/src/controller_server.cpp
@@ -301,9 +301,6 @@ ControllerServer::on_deactivate(const rclcpp_lifecycle::State & /*state*/)
   costmap_ros_->deactivate();
 
   publishZeroVelocity();
-  for (auto & controller : controllers_) {
-    controller.second->reset();
-  }
   vel_publisher_->on_deactivate();
 
   remove_on_set_parameters_callback(dyn_params_handler_.get());
@@ -560,7 +557,7 @@ void ControllerServer::computeControl()
     return;
   } catch (nav2_core::ControllerTimedOut & e) {
     RCLCPP_ERROR(this->get_logger(), "%s", e.what());
-    publishZeroVelocity();
+    onGoalExit();
     std::shared_ptr<Action::Result> result = std::make_shared<Action::Result>();
     result->error_code = Action::Result::CONTROLLER_TIMED_OUT;
     action_server_->terminate_current(result);