From 388e1116cf55d05ff02fe27a25cc4b25f86d669c Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Fri, 5 Jan 2024 17:27:46 -0800 Subject: [PATCH 1/5] adding github action lint --- .github/lint.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/lint.yml diff --git a/.github/lint.yml b/.github/lint.yml new file mode 100644 index 00000000000..befe1da7ec4 --- /dev/null +++ b/.github/lint.yml @@ -0,0 +1,20 @@ +name: Lint +on: + pull_request: + +jobs: + ament_lint_general: + name: ament_${{ matrix.linter }} + runs-on: ubuntu-latest + container: + image: rostooling/setup-ros-docker:ubuntu-jammy-ros-rolling-ros-base-latest + strategy: + fail-fast: false + matrix: + linter: [copyright, xmllint, cpplint, uncrustify, pep257, flake8] + steps: + - uses: actions/checkout@v2 + - uses: ros-tooling/action-ros-lint@v0.1 + with: + linter: ${{ matrix.linter }} + distribution: rolling From 91d289f68ce04b5f1a18121a05291d65dc220bd9 Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Fri, 5 Jan 2024 17:30:45 -0800 Subject: [PATCH 2/5] move linting file Signed-off-by: Steve Macenski --- .github/{ => workflows}/lint.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/{ => workflows}/lint.yml (100%) diff --git a/.github/lint.yml b/.github/workflows/lint.yml similarity index 100% rename from .github/lint.yml rename to .github/workflows/lint.yml From d25f2ba4886adfe50ee530f7c995e92cd40a641e Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Fri, 5 Jan 2024 17:34:56 -0800 Subject: [PATCH 3/5] try all wildcard --- .github/workflows/lint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index befe1da7ec4..ed10f7562e6 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -18,3 +18,4 @@ jobs: with: linter: ${{ matrix.linter }} distribution: rolling + package-name: * \ No newline at end of file From 26a4c14157800553c6c5a8d782b750977629b209 Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Fri, 5 Jan 2024 17:36:05 -0800 Subject: [PATCH 4/5] stringify --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index ed10f7562e6..5c04a4e2a41 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -18,4 +18,4 @@ jobs: with: linter: ${{ matrix.linter }} distribution: rolling - package-name: * \ No newline at end of file + package-name: "*" \ No newline at end of file From 2b1b0f3b54a5804cde1b34a9008017ef0d06b1be Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Fri, 5 Jan 2024 17:41:29 -0800 Subject: [PATCH 5/5] removing copyright check --- .github/workflows/lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 5c04a4e2a41..635086a5227 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -11,11 +11,11 @@ jobs: strategy: fail-fast: false matrix: - linter: [copyright, xmllint, cpplint, uncrustify, pep257, flake8] + linter: [xmllint, cpplint, uncrustify, pep257, flake8] steps: - uses: actions/checkout@v2 - uses: ros-tooling/action-ros-lint@v0.1 with: linter: ${{ matrix.linter }} distribution: rolling - package-name: "*" \ No newline at end of file + package-name: "*"