Make nav2_core an INTERFACE library. #4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, it exports header files, but it does not have any implementation itself. Make sure to make an INTERFACE library so downstreams can have access to the header files. Note that this also required a change to nav2_graceful_controller, since it was erroneously getting a visualization_msgs dependency from nav2_core. Signed-off-by: Chris Lalancette <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
SteveMacenski
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
nav2_core exports header files, but it does not have any implementation itself. Make sure to make an INTERFACE library so downstreams can have access to the header files.
Note that this also required a change to nav2_graceful_controller, since it was erroneously getting a visualization_msgs dependency from nav2_core.
Description of documentation updates required from your changes
None needed.
Future work that may be required in bullet points
This is part of the follow-up work for #4357 ; more PRs will be following to transition more packages.
For Maintainers: