-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ros2] image_view only subscribe to raw #824
Comments
FYI @JWhitleyWork |
Probably I know why the second remapping is not happening, when the code susbcribes to the topic it uses |
Thinking a little bit more about the second issue, using this remapping is fixed, maybe we should document this better: ros2 run image_view image_view compressed "/image/compressed:=/camera/image/compressed" |
I created this PR #825 |
I have the same problem: Only using transport raw... In Ros2 Humble. |
So is it possible you're just using the wrong command line? If I do the following:
Which is what is shown in the image_transport_tutorials README, then things work (even using what is in rolling debs right now):
I think this is because without the "-p" newer ROS 2 versions are interpreting this as a remap rather than a parameter |
Ok - I might have spoken too soon - I get the "compressed" message (so parameter is going through) but the remap doesn't actually work.. so then:
Also, if I update the image_transport_tutorials my_subscriber to use transport hints and switch to compressed, it also does the remappings incorrectly - further confirming the bug is in image_transport |
There is definitely something funky going on with the remapping - this fully works against current rolling debs:
|
Based on these comments - I opened #850 to at least correct the help string for image_view to the proper format |
I believe that #851 is the correct approach to fix the remap issues - still need to apply that to this particular node |
#851 fixes the remapping (in rolling, which means jazzy and beyond - as noted in the PR, this would break anyone who has been manually fixing the remapping issue, so I don't think we should release it into Iron or earlier) For the image_transport selection - it appears our real issue is lack of documentation - I've specifically called out this image_transport part in my documentation ticket: #848 |
I'm testing this repository in particular
image_view
and I found several issues:I'm publishing images using this command
then I try to subscribe to "raw" image using:
Up to this point all work fine, but the issues start when I try to use a different image transport plugin
ros2 run image_view image_view compressed image:=/camera/image compressed [INFO] [1688051408.660552694] [image_view_node]: Using transport "raw"
But I always see this trace :
Using transport "raw"
. This is happening because theNodeOptions
is resetting the parameters no matter what you define in the cmd.I tried
But I'm getting the same result, the solution should be something like this. Parse the arguments.
Remapping
Then the second problem that I'm facing is the remapping, when I use the "raw" plugin I'm able to remap the topic from "image" to the one that I want, But If I hardcoded the code to use "compressed" images, the topic is not remapped. I checked this addiing some traces.
are these know issues? or am I doing something wrong ?
Happy to open PRs and find a solution.
The text was updated successfully, but these errors were encountered: