Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value of min_points_per_voxel changed during migration #430

Open
ymd-stella opened this issue Nov 5, 2023 · 0 comments
Open

Default value of min_points_per_voxel changed during migration #430

ymd-stella opened this issue Nov 5, 2023 · 0 comments

Comments

@ymd-stella
Copy link

ymd-stella commented Nov 5, 2023

The default value of min_points_per_voxel is changed in migration (#398).

The default value in melodic was 1.

gen.add ("min_points_per_voxel", int_t, 0, "The minimum number of points required for a voxel to be used.", 1, 1, 100000)

After migration, it was changed to 2, but I could not find any reference to the reason for this.

min_points_per_voxel_desc.name, rclcpp::ParameterValue(2), min_points_per_voxel_desc);

If this is set to 2 or higher and the leaf_size is small relative to the density of the point cloud, part of the pointcloud may disappear, which can be a surprise to someone unaware of this parameter. Therefore, I think this default value should be restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant