Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maintainer cross check to review guidelines #36047

Open
tfoote opened this issue Feb 6, 2023 · 0 comments
Open

Add maintainer cross check to review guidelines #36047

tfoote opened this issue Feb 6, 2023 · 0 comments

Comments

@tfoote
Copy link
Member

tfoote commented Feb 6, 2023

It was removed in #36034 this is a follow up.

We should be checking who the maintainer is to make sure that arbitrary people don't just release over a past release etc.

Obviously that info is not in this repo. But I think that we should have some checks on that. Optimal would be a linter that checks. But some guide in the docs that says that the releaser should be delegated by the maintainer etc would be good. I'm not sure really where we should go with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants