Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CMAKE_INSTALL_LIBDIR to lib. #2

Merged

Conversation

nuclearsandwich
Copy link
Contributor

When migrating Rolling to new platforms in ros/rosdistro#32036 a problem with the migration script (ros/rosdistro#32128) caused patches on release/, rpm/, and debian/ branches to be wiped out.

I took a backup before the migration and am in the process of re-applying lost patches and this is one of them.

@wxmerkt with your approval I'll merge this PR and then bloom a debinc / release revision of apriltag in order to restore this patch behavior. If this patch shouldn't be restored for some reason then this PR can just be closed.

Thanks and apologies for the churn.

@nuclearsandwich nuclearsandwich self-assigned this Feb 16, 2022
@wxmerkt
Copy link
Member

wxmerkt commented Feb 16, 2022

Should be fine to restore this patch :-)

@nuclearsandwich nuclearsandwich merged commit e347636 into release/rolling/apriltag Feb 17, 2022
@nuclearsandwich nuclearsandwich deleted the nuclearsandwich/release/patchrestore branch February 17, 2022 20:41
@nuclearsandwich
Copy link
Contributor Author

Once ros/rosdistro#32225 merges this should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants