Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make wait set growable #278

Open
nnmm opened this issue Oct 6, 2022 · 0 comments
Open

Make wait set growable #278

nnmm opened this issue Oct 6, 2022 · 0 comments
Labels
enhancement

Comments

@nnmm
Copy link
Contributor

nnmm commented Oct 6, 2022

Currently, on each iteration of rclrs::spin(), the wait set is regenerated from scratch.

It would be more efficient to be able to push new waitable entities, if any, into the existing wait set – and re-allocating storage if the capacity is not sufficient. This could work a bit like a Vec – doubling capacity each time the capacity is exceeded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nnmm