Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connext security tests failing on Windows #488

Open
jacobperron opened this issue Jun 25, 2020 · 3 comments
Open

Connext security tests failing on Windows #488

jacobperron opened this issue Jun 25, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jacobperron
Copy link
Member

For example: Build Status

In #454, we updated our Windows CI to install OpenSSL 1.1.1, but ran into issues with tests using Connext in test_security. The tests were disabled in ros2/system_tests#433. This is a follow-up ticket to track progress towards re-enabling those security tests.

Connext requires an EOL-version of OpenSSL (1.0.2g). A convention for selecting the version of OpenSSL was introduced in ros2/system_tests#409, and used to fix the tests for macOS in #436.

It's still not clear why the tests are failing on Windows CI. Locally, I do not have an issue running the tests.

@jacobperron jacobperron added the bug Something isn't working label Jun 25, 2020
@dirk-thomas
Copy link
Member

See #488.

@clalancette
Copy link
Contributor

I think that this has been long solved; at least, the latest nightlies show test_security passing on Windows: https://ci.ros2.org/view/nightly/job/nightly_win_rel/2200/testReport/test_security/ .

As such, I'm going to close this out. If I'm wrong about this, please feel free to reopen.

@nuclearsandwich
Copy link
Member

Actually, as I discovered when working on the connext 6 support (#614) these tests are not currently run for connext on Windows.

https://github.com/ros2/system_tests/blob/44ac714f2cd201b2a2c98949595e953d5a289191/test_security/CMakeLists.txt#L249-L262

I think we can update that conditional to run them for rmw_connextdds when rti-connext-dds >= 6.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants