Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin cryptography version #507

Open
dirk-thomas opened this issue Aug 27, 2020 · 3 comments
Open

Unpin cryptography version #507

dirk-thomas opened this issue Aug 27, 2020 · 3 comments
Labels

Comments

@dirk-thomas
Copy link
Member

Follow up of #506 once a newer cryptography version is available with the removed API.

kyrofa added a commit to kyrofa/sros2 that referenced this issue Sep 9, 2020
The SROS2 utilities use the Cryptography library, which doesn't
officially support S/MIME. As a result, we had to hit the SSL bindings
directly to get that functionality. These bindings were removed in v3.1
of Cryptography, which means the SROS2 utilities were stuck on v3.0 at
the latest. However, Cryptography has added an official S/MIME API which
is far easier to use than the raw SSL API. Update the SROS2 utilities to
use it.

Resolve ros2#239
Update ros2/ci#507

Signed-off-by: Kyle Fazzari <[email protected]>
@clalancette
Copy link
Contributor

@kyrofa I'm going to assign this to you, as you are already sort of working on this in ros2/sros2#240. If you don't want to be assigned, feel free to unassign yourself.

@kyrofa
Copy link
Member

kyrofa commented Sep 10, 2020

Sounds good!

@ros-discourse
Copy link

This issue has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-2-tsc-meeting-agenda-2020-09-17/16464/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants