Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github templates for bug reports and features. Also links for important ROS related sites. #782

Closed
wants to merge 11 commits into from
Closed

Add github templates for bug reports and features. Also links for important ROS related sites. #782

wants to merge 11 commits into from

Conversation

peterborkuti
Copy link

Hi,
I checked #779 and I thought, I could help.
This is what you were thinking about?

You can try the configurations here:
https://github.com/peterborkuti/launch/issues

Here is how it looks like:
image

image

image

I was thinking about creating drop downs with OS and DDS versions.

Hope you like it
Péter

@DLu
Copy link
Contributor

DLu commented May 24, 2024

👍

fujitatomoya
fujitatomoya reviewed May 26, 2024
View reviewed changes
Copy link

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is good enhancement! thanks for the PR.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@peterborkuti peterborkuti force-pushed the github_templates branch 2 times, most recently from d6ca727 to 47a15a4 Compare May 27, 2024 22:07
fujitatomoya
fujitatomoya requested changes May 27, 2024
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@peterborkuti peterborkuti force-pushed the github_templates branch 6 times, most recently from 7514aa5 to 62a683c Compare May 28, 2024 12:55
@peterborkuti
Add templates
36b4221 
Signed-off-by: Peter Borkuti <[email protected]>
@audrow audrow self-assigned this Jun 6, 2024
audrow
audrow reviewed Jun 6, 2024
View reviewed changes
Copy link
Member

@audrow audrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

I made a few small suggestions.

It's also probably best to remove the existing issue template correct?

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
@audrow audrow mentioned this pull request Jun 6, 2024
Open
peterborkuti and others added 6 commits June 11, 2024 18:23
@peterborkuti @audrow
Update .github/ISSUE_TEMPLATE/bug_report.yml
2800da8 
Co-authored-by: Audrow Nash <[email protected]>
Signed-off-by: Peter Borkuti <[email protected]>
@peterborkuti @audrow
Update .github/ISSUE_TEMPLATE/bug_report.yml
1166545 
Co-authored-by: Audrow Nash <[email protected]>
Signed-off-by: Peter Borkuti <[email protected]>
@peterborkuti @christophebedard
Update .github/ISSUE_TEMPLATE/bug_report.yml
8d65cbe 
Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: Peter Borkuti <[email protected]>
@peterborkuti @audrow
Update .github/ISSUE_TEMPLATE/config.yml
ba8fc7e 
Co-authored-by: Audrow Nash <[email protected]>
Signed-off-by: Peter Borkuti <[email protected]>
@peterborkuti @christophebedard
Update .github/ISSUE_TEMPLATE/bug_report.yml
ac947de 
Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: Peter Borkuti <[email protected]>
@peterborkuti
remove [bug] from title
585d095 
Signed-off-by: Peter Borkuti <[email protected]>
@peterborkuti
Update bug_report.yml
f471e6f 
Signed-off-by: Peter Borkuti <[email protected]>
peterborkuti
peterborkuti commented Jun 11, 2024
View reviewed changes
Copy link
Author

@peterborkuti peterborkuti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestions.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
@audrow
Copy link
Member

audrow commented Jun 17, 2024 •
edited
Loading

@peterborkuti, should the existing template be removed in this PR?

Also, make sure the DCO check passes. After these, we should be able to get this in.

@peterborkuti
remove title
ac4022d 
Signed-off-by: Peter Borkuti <[email protected]>
@peterborkuti
remove old template
f4f64d3 
Signed-off-by: Peter Borkuti <[email protected]>
@peterborkuti
Copy link
Author

@audrow
I hope, its done. I removed the old template and fixed the DCO issues.

@peterborkuti
Copy link
Author

Hi,
Is there any issue with this version?

@erickisos erickisos mentioned this pull request Sep 20, 2024
Closed
@peterborkuti @fujitatomoya
Update .github/ISSUE_TEMPLATE/feature_request.yml
ff397ff 
Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Peter Borkuti <[email protected]>
@fujitatomoya fujitatomoya mentioned this pull request Nov 13, 2024
Open
@fujitatomoya
Copy link

The current plan is to go with org template ros2/.github#3, so i will go ahead to close this for now. if the repository specific templates are required, of course we can do that for each repository templete.

@peterborkuti
Copy link
Author

peterborkuti commented Nov 22, 2024 •
edited
Loading

Dear @fujitatomoya
As I was working on this for many months and I did 10+ times what you asked, I would be very happy if you would ask me to do it for the ros2 repo. Of course, you can do whatever yo want. But it is a bit rude, I may say.
Now I think, that it was a good thing, that I tested the ROS2 dev community with this pull request.

@fujitatomoya
Copy link

@peterborkuti

My apology for this decision change after all these iteration, but this sometimes happens after discussion with developers. I really appreciate you for being so responsive to apply the changes, thanks for that. i did not mean to be rude. as you pointed out, i should have been much louder on this change with you to share the progress. (i missed you on ros2/.github#3, so added as co-author, sorry about that too.)

besides, if this is still better for this repository specific templates, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@audrow audrow audrow left review comments

@christophebedard christophebedard christophebedard left review comments

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

@methylDragon methylDragon Awaiting requested review from methylDragon

@wjwwood wjwwood Awaiting requested review from wjwwood

Assignees

@audrow audrow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterborkuti @DLu @audrow @fujitatomoya @christophebedard