Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress toward Quality Level 1 #88

Closed
33 tasks done
brawner opened this issue Feb 6, 2020 · 1 comment
Closed
33 tasks done

Progress toward Quality Level 1 #88

brawner opened this issue Feb 6, 2020 · 1 comment
Assignees

Comments

@brawner
Copy link
Contributor

brawner commented Feb 6, 2020

This issue tracks the progression of packages in rcl_interaces that have been deemed necessary for Quality Level 1 and a 1.0 version level. It follows the outline described in REP 2004.

The packages slated for Quality Level 1 for ROS 2 Foxy are:

  • action_msgs
  • builtin_interfaces
  • composition_interfaces
  • lifecycle_msgs
  • rcl_interfaces
  • rosgraph_msgs
  • statistics_msgs

Excluded for Quality Level 1 at this time:

  • test_msgs

Progress common to all packages:

  • Version Policy
    • Follows ROS Core Quality Declaration
  • Version >= 1.0.0
  • Change Control Process
    • Follows ROS Core
  • No testing required because these packages just define messages and services

Documentation

  • Declared set of licenses
  • Copyright statement in each source file
    • Copyright statements aren't needed in msg/srv files

Dependencies:

  • non-ROS dependencies are equivalent level 1

Platform Support

  • Supports all tier 1 platforms

Progress of specific packages

action_msgs

Documentation

Dependencies:

  • Runtime "ROS" dependencies are level 1
    • rosidl_default_runtime
    • builtin_interfaces
    • unique_identifier_msgs
  • non-ROS dependencies are equivalent level 1

builtin_interfaces

Documentation

  • Per-feature documentation.
  • Per-item documentation in public API.
  • Quality Declaration document

Dependencies:

  • Runtime "ROS" dependencies are level 1
    • rosidl_default_runtime

Specific comments/recommendations:

composition_interfaces

Documentation

  • Per-feature documentation.
  • Per-item documentation in public API.
  • Quality Declaration document

Dependencies:

  • Runtime "ROS" dependencies are level 1
    • rosidl_default_runtime
    • rcl_interfaces

lifecycle_msgs

Documentation

  • Per-feature documentation.
    • Should also point to lifecycle nodes documentation
  • Per-item documentation in public API.
    • Needed in (ChangeState.srv, GetAvailableStates.srv, GetAvailableTransitions.srv, GetState.srv)
  • Quality Declaration document

Dependencies:

  • Runtime "ROS" dependencies are level 1
    • rosidl_default_runtime

rcl_interfaces

  • Per-feature documentation.
  • Per-item documentation in public API.
    • See below
  • Quality Declaration document

Dependencies:

  • Runtime "ROS" dependencies are level 1
    • builtin_interfaces
    • rosidl_default_runtime

rosgraph_msgs

Documentation

  • Per-feature documentation
    • ROS 1 feature level docs exist
  • Per-item documentation in public API.
  • Quality Declaration document

Dependencies:

  • Runtime "ROS" dependencies are level 1
    • builtin_interfaces
    • rosidl_default_runtime
@chapulina
Copy link

All packages are level 1 😄 #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants