Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain ID not changable on rclpy Node Class Parameter #487

Closed
fujitatomoya opened this issue Dec 20, 2019 · 1 comment
Closed

Domain ID not changable on rclpy Node Class Parameter #487

fujitatomoya opened this issue Dec 20, 2019 · 1 comment

Comments

@fujitatomoya
Copy link
Collaborator

Feature request

Feature description

ability to set the Domain ID on a per-node basis.

the same ability with ros2/rclcpp#910

Implementation considerations

  1. add domain id with rclpy Node Class option. (default RCL_NODE_OPTIONS_DEFAULT_DOMAIN_ID)
  2. if it is RCL_NODE_OPTIONS_DEFAULT_DOMAIN_ID, the rcl overrides domain id with ROS_DOMAIN_ID environmental variable.
@fujitatomoya
Copy link
Collaborator Author

closing since this is duplication of #484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant