From 1bb128ba1487a13046dd5673969bee53edd0bf83 Mon Sep 17 00:00:00 2001 From: Christophe Bedard Date: Thu, 13 Jun 2024 15:12:50 -0400 Subject: [PATCH] Make rmw_destroy_wait_set return RMW_RET_INVALID_ARGUMENT (#152) Signed-off-by: Christophe Bedard --- rmw_connextdds_common/src/common/rmw_waitset.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/rmw_connextdds_common/src/common/rmw_waitset.cpp b/rmw_connextdds_common/src/common/rmw_waitset.cpp index 73fe713a..dc4fa27e 100644 --- a/rmw_connextdds_common/src/common/rmw_waitset.cpp +++ b/rmw_connextdds_common/src/common/rmw_waitset.cpp @@ -105,9 +105,7 @@ rmw_api_connextdds_create_wait_set( rmw_ret_t rmw_api_connextdds_destroy_wait_set(rmw_wait_set_t * rmw_ws) { - // TODO(asorbini): Return RMW_RET_INVALID_ARGUMENT. We return RMW_RET_ERROR - // because that's what's expected by test_rmw_implementation - RMW_CHECK_ARGUMENT_FOR_NULL(rmw_ws, RMW_RET_ERROR); + RMW_CHECK_ARGUMENT_FOR_NULL(rmw_ws, RMW_RET_INVALID_ARGUMENT); RMW_CHECK_TYPE_IDENTIFIERS_MATCH( rmw_ws, rmw_ws->implementation_identifier,