Bring zenoh router via vendor. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franco Cipollone <[email protected]>
Closed
Signed-off-by: Franco Cipollone <[email protected]>
|
As mentioned in the issue, for the moment it solves the issue of installing the router. In the future, this implementation will change. |
clalancette
requested changes
Nov 16, 2023
clalancette
approved these changes
Nov 17, 2023
| zenoh | ||
| PREFIX ${CMAKE_BINARY_DIR}/_cargo_deps | ||
| GIT_REPOSITORY https://github.com/eclipse-zenoh/zenoh.git | ||
| GIT_TAG master |
There was a problem hiding this comment.
I think for consistency, we should probably pin this to a particular hash. But I think we should also do the same thing for zenoh_c_vendor, so I'll open a separate PR doing that.
delete-merged-branch
bot
deleted the
francocipollone/bring_zenoh_router
branch
Yadunund
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Bring zenoh router via vendor. Signed-off-by: Franco Cipollone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #64
Summary
This is an open debate for bringing zenoh router into the workspace.
A simple implementation is proposed here for the time being.
Pendings
Test it
zenohdby default uses a configuration in which it uses rest API plugin. In our case we are not using plugins and therefore we are not bringing them for the time being.For testing it there, after colcon build + source install:
Run
ros2 run rmw_zenoh_cpp init_rmw_zenoh_router