Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros2doctor: add support for warning on out of date packages #343

Closed
tfoote opened this issue Sep 30, 2019 · 5 comments
Closed

ros2doctor: add support for warning on out of date packages #343

tfoote opened this issue Sep 30, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@tfoote
Copy link
Contributor

tfoote commented Sep 30, 2019

A common error that people have is that they may have old our outdated packages on their system. This is most common with build pipeline tools, but can also have an effect due to a partial install or update of their debian packages.

ros2doctor could collect the list of all local packages in the workspace with their version number and then check against a declared rosdistro for the released version number. And if the latest version number and the version in the rosdistro do not match it should add it to the warnings.

We don't have the rosdistro cache for our latest bootstrap packages, but there may be an approach that would be reasonable to query pypi for the latest version or the apt servers, or possibly a github API. Bloom has logic like this to warn if it's not the latest version that could potentially be replicated.

In the report mode it would be valuable to be able to export the list of packages present on the system as well as their version number.

In report mode another extension that would be valuable would be the vcs export --exact of the workspace for easier reproduction/debugging. As well as potentially listing the exact debian packages (with build numbers) that have been installed for easier reproduction.

@tfoote tfoote added the enhancement New feature or request label Sep 30, 2019
@claireyywang claireyywang self-assigned this Oct 2, 2019
@claireyywang claireyywang added the in progress Actively being worked on (Kanban column) label Oct 8, 2019
@claireyywang
Copy link
Contributor

I'm using vcs export --exact API to get local package information, but it will make this check directory sensitive, since vcs only lists packages installed within the directory it is called. roswtf also had the same property, so I guess it is ok for ros2doctor to be the same?

@dirk-thomas
Copy link
Member

How do you know the location of the sources of the packages? The same problem was discussed in #75.

@claireyywang
Copy link
Contributor

Good question. I think that I'm facing the same dilemma as in the discussion. vcstool only works if the workspace it's called in contains source, thus this check would not work in some cases. I am unable to figure out a good solution at the moment, but open to suggestions.

@dirk-thomas
Copy link
Member

In a similar case we are using colcon to actually find the source directory of packages (see colcon/colcon-cd#1). Not sure if it is desired to depend on that here though...

@claireyywang
Copy link
Contributor

closing since pr is merged

@wuffle-ros wuffle-ros bot removed the in progress Actively being worked on (Kanban column) label Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants