From da529d86fbacfde451c6e9b3bf1689e68be0d798 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Steven!=20Ragnar=C3=B6k?= Date: Tue, 24 May 2022 17:47:52 -0700 Subject: [PATCH] Add failing packages to build blacklists on Rolling and Humble. (#240) These packages are failing to build on Rolling Ubuntu amd64 - [swri_console_util](https://build.ros2.org/job/Rbin_uJ64__swri_console_util__ubuntu_jammy_amd64__binary) - [swri_geometry_util](https://build.ros2.org/job/Rbin_uJ64__swri_geometry_util__ubuntu_jammy_amd64__binary) - [swri_prefix_tools](https://build.ros2.org/job/Rbin_uJ64__swri_prefix_tools__ubuntu_jammy_amd64__binary) - [swri_roscpp](https://build.ros2.org/job/Rbin_uJ64__swri_roscpp__ubuntu_jammy_amd64__binary) These packages are failing to build on Rolling RHEL 8 x86_64 - [swri_console_util](https://build.ros2.org/job/Rbin_rhel_el864__swri_console_util__rhel_8_x86_64__binary) - [swri_geometry_util](https://build.ros2.org/job/Rbin_rhel_el864__swri_geometry_util__rhel_8_x86_64__binary) - [swri_prefix_tools](https://build.ros2.org/job/Rbin_rhel_el864__swri_prefix_tools__rhel_8_x86_64__binary) - [swri_roscpp](https://build.ros2.org/job/Rbin_rhel_el864__swri_roscpp__rhel_8_x86_64__binary) And on Humble Ubuntu amd64 - [swri_console_util](https://build.ros2.org/job/Hbin_uJ64__swri_console_util__ubuntu_jammy_amd64__binary) - [swri_geometry_util](https://build.ros2.org/job/Hbin_uJ64__swri_geometry_util__ubuntu_jammy_amd64__binary) - [swri_prefix_tools](https://build.ros2.org/job/Hbin_uJ64__swri_prefix_tools__ubuntu_jammy_amd64__binary) - [swri_roscpp](https://build.ros2.org/job/Hbin_uJ64__swri_roscpp__ubuntu_jammy_amd64__binary) And Humble RHEL 8 - [swri_console_util](https://build.ros2.org/job/Hbin_rhel_el864__swri_console_util__rhel_8_x86_64__binary) - [swri_geometry_util](https://build.ros2.org/job/Hbin_rhel_el864__swri_geometry_util__rhel_8_x86_64__binary) - [swri_prefix_tools](https://build.ros2.org/job/Hbin_rhel_el864__swri_prefix_tools__rhel_8_x86_64__binary) - [swri_roscpp](https://build.ros2.org/job/Hbin_rhel_el864__swri_roscpp__rhel_8_x86_64__binary) Normally for packages which are failing to build globally the first thing I would do is remove the package from the release list in the distribution files. That approach has the advantage of allowing a simple re-release to trigger a new attempt to build the blocked packages. However, when using that approach downstream jobs are not detected and blocked along with the blacklisted job which means that packages which depend on "dropped" releases will just start failing with an error installing the dropped package. I've come around to the idea that it's better for the build farm overall if packages are blocked via build configuration unless the entire release is broken and should be removed. --- humble/release-build.yaml | 4 ++++ humble/release-rhel-build.yaml | 4 ++++ humble/release-ubuntu-arm64-build.yaml | 4 ++++ rolling/release-build.yaml | 4 ++++ rolling/release-rhel-build.yaml | 4 ++++ rolling/release-ubuntu-arm64-build.yaml | 4 ++++ 6 files changed, 24 insertions(+) diff --git a/humble/release-build.yaml b/humble/release-build.yaml index 9ac6726b..4116ae26 100644 --- a/humble/release-build.yaml +++ b/humble/release-build.yaml @@ -15,6 +15,10 @@ notifications: - audrow+build.ros2.org@openrobotics.org - ros2-buildfarm-humble@googlegroups.com maintainers: true +package_blacklist: +- swri_console_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_geometry_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_roscpp # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 sync: package_count: 499 packages: [desktop] diff --git a/humble/release-rhel-build.yaml b/humble/release-rhel-build.yaml index ad082db7..f10f98f4 100644 --- a/humble/release-rhel-build.yaml +++ b/humble/release-rhel-build.yaml @@ -48,6 +48,10 @@ package_blacklist: - ros1_bridge # ROS Noetic has no RPM packages for RHEL - sdformat_test_files # sdformat has no RPM packages for RHEL 8 - sdformat_urdf # sdformat has no RPM packages for RHEL 8 +- swri_console_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_geometry_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_prefix_tools # Fix is merged but unreleased. https://github.com/swri-robotics/marti_common/pull/665 +- swri_roscpp # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 - tracetools_analysis # jupyter-notebook has no RPM package for RHEL - ublox_gps # asio has no RPM package for RHEL 8 - usb_cam # ffmpeg has no RPM package for RHEL diff --git a/humble/release-ubuntu-arm64-build.yaml b/humble/release-ubuntu-arm64-build.yaml index 657fb8dd..864fa1ff 100644 --- a/humble/release-ubuntu-arm64-build.yaml +++ b/humble/release-ubuntu-arm64-build.yaml @@ -15,6 +15,10 @@ notifications: sync: package_count: 499 packages: [desktop] +package_blacklist: +- swri_console_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_geometry_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_roscpp # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 repositories: keys: - | diff --git a/rolling/release-build.yaml b/rolling/release-build.yaml index 36a083be..a69acabd 100644 --- a/rolling/release-build.yaml +++ b/rolling/release-build.yaml @@ -15,6 +15,10 @@ notifications: - steven+build.ros2.org@openrobotics.org - ros2-buildfarm-rolling@googlegroups.com maintainers: true +package_blacklist: +- swri_console_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_geometry_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_roscpp # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 sync: package_count: 499 packages: [desktop] diff --git a/rolling/release-rhel-build.yaml b/rolling/release-rhel-build.yaml index 31dd5ff2..374a94ee 100644 --- a/rolling/release-rhel-build.yaml +++ b/rolling/release-rhel-build.yaml @@ -48,6 +48,10 @@ package_blacklist: - ros1_bridge # ROS Noetic has no RPM packages for RHEL - sdformat_test_files # sdformat has no RPM packages for RHEL 8 - sdformat_urdf # sdformat has no RPM packages for RHEL 8 +- swri_console_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_geometry_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_prefix_tools # Fix is merged but unreleased. https://github.com/swri-robotics/marti_common/pull/665 +- swri_roscpp # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 - tracetools_analysis # jupyter-notebook has no RPM package for RHEL - ublox_gps # asio has no RPM package for RHEL 8 - usb_cam # ffmpeg has no RPM package for RHEL diff --git a/rolling/release-ubuntu-arm64-build.yaml b/rolling/release-ubuntu-arm64-build.yaml index 352b2cad..6d6f715d 100644 --- a/rolling/release-ubuntu-arm64-build.yaml +++ b/rolling/release-ubuntu-arm64-build.yaml @@ -12,6 +12,10 @@ notifications: - steven+build.ros2.org@openrobotics.org - ros2-buildfarm-rolling@googlegroups.com maintainers: true +package_blacklist: +- swri_console_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_geometry_util # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 +- swri_roscpp # Build failures on all platforms. https://github.com/swri-robotics/marti_common/issues/665 sync: package_count: 499 packages: [desktop]