Skip to content

Commit

Permalink
Workaround for flaky test_play_services running with fastrtps (#1556)
Browse files Browse the repository at this point in the history
- Workaround for #1311
- Gracefully stop player in TearDown() before calling rclcpp::shutdown()
in destructor.

Signed-off-by: Michael Orlov <[email protected]>
  • Loading branch information
morlov-apexai authored Feb 2, 2024
1 parent a505a56 commit 54be479
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,12 @@ class PlaySrvsTest : public RosBag2PlayTestFixture
ASSERT_TRUE(cli_stop_->wait_for_service(service_wait_timeout_));
}

void TearDown() override
{
// Gracefully stop player before calling rclcpp::shutdown() in destructor
player_->stop();
}

/// Call a service client, and expect it to successfully return within a reasonable timeout
template<typename Srv>
typename Srv::Response::SharedPtr successful_call(
Expand Down

0 comments on commit 54be479

Please sign in to comment.