From 744cdf0420189b4435b9c8b2839899b1b80d23f5 Mon Sep 17 00:00:00 2001 From: Chris Lalancette Date: Wed, 12 Jul 2023 12:04:44 -0400 Subject: [PATCH] Fix the build with rmw_fastrtps_dynamic. (#1416) When building with *only* rmw_fastrtps_dynamic, there is no test named "test_play_services__rmw_fastrtps_cpp" to mark as xfail. Instead, it is called "test_play_services__rmw_fastrtps_dynamic_cpp", so make sure to add a different xfail marking for that test. Signed-off-by: Chris Lalancette --- rosbag2_transport/CMakeLists.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/rosbag2_transport/CMakeLists.txt b/rosbag2_transport/CMakeLists.txt index b1fb977656..5c7caa8ea1 100644 --- a/rosbag2_transport/CMakeLists.txt +++ b/rosbag2_transport/CMakeLists.txt @@ -242,9 +242,12 @@ function(create_tests_for_rmw_implementation) ament_add_test_label(test_play_services__rmw_cyclonedds_cpp xfail) endif() - if(${rmw_implementation} MATCHES "rmw_fastrtps(.*)") + if(${rmw_implementation} MATCHES "rmw_fastrtps_cpp") ament_add_test_label(test_play_services__rmw_fastrtps_cpp xfail) endif() + if(${rmw_implementation} MATCHES "rmw_fastrtps_dynamic_cpp") + ament_add_test_label(test_play_services__rmw_fastrtps_dynamic_cpp xfail) + endif() endfunction() if(BUILD_TESTING)