Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpr job seems running multiple tests in parallel #1880

Open
MichaelOrlov opened this issue Dec 10, 2024 · 1 comment
Open

Rpr job seems running multiple tests in parallel #1880

MichaelOrlov opened this issue Dec 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@MichaelOrlov
Copy link
Contributor

Description

Rpr and Jpr jobs seems running multiple tests in parallel

Expected Behavior

Rpr and Jpr jobs run tests sequentially

Actual Behavior

Reference to the failing Rpr job https://build.ros2.org/job/Rpr__rosbag2__ubuntu_noble_amd64/477/testReport/junit/(root)/projectroot/test_record_all__rmw_fastrtps_cpp/
From the log I see that in the published_messages_from_multiple_topics_are_recorded test, we've got more messages that we expected.

TEST_F(RecordIntegrationTestFixture, published_messages_from_multiple_topics_are_recorded)
{
auto array_message = get_messages_arrays()[0];
array_message->float32_values = {{40.0f, 2.0f, 0.0f}};
array_message->bool_values = {{true, false, true}};
std::string array_topic = "/array_topic";
auto string_message = get_messages_strings()[0];
string_message->string_value = "Hello World";
std::string string_topic = "/string_topic";
rosbag2_test_common::PublicationManager pub_manager;
pub_manager.setup_publisher(array_topic, array_message, 2);
pub_manager.setup_publisher(string_topic, string_message, 2);
rosbag2_transport::RecordOptions record_options =
{true, false, false, {}, {}, {}, {"/rosout"}, {}, {}, "rmw_format", 100ms};
auto recorder = std::make_shared<rosbag2_transport::Recorder>(

And I see that the Rosbag2 recorder subscribed to the
[INFO] [1733734416.350351887] [rosbag2_recorder]: Subscribed to topic '/composable_recorder_test_string_topic'
However, we publish on this topic only from the other test recorder_can_automatically_start_recording_after_composition
TEST_P(
ComposableRecorderIntegrationTests,
recorder_can_automatically_start_recording_after_composition) {
const size_t num_messages_to_publish = 5;
auto string_message = get_messages_strings()[0];
string_message->string_value = "Hello World";
const std::string test_topic_name = "/composable_recorder_test_string_topic";
rosbag2_test_common::PublicationManager pub_manager;

To Reproduce

N/A
** Steps to reproduce the behavior, e.g.

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. Logs print error '...' **

System (please complete the following information)

  • OS: Ubuntu 22.04, 24.04
  • ROS 2 Distro: Rolling, Jazzy
  • Install Method: CI, Rpr job
  • Version: Rolling

Additional context

** Add any other context about the problem here **

@MichaelOrlov MichaelOrlov added the bug Something isn't working label Dec 10, 2024
@MichaelOrlov
Copy link
Contributor Author

@claraberendsen @clalancette @cottsay This is an example of the Rpr job failure that I mentioned on today's ROS PMC meeting with suspicion that the Rpr job runs multiple tests at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants