From 5006e3796548f89f78e521ad1f7ff5a2bb12719a Mon Sep 17 00:00:00 2001 From: Mikael Arguedas Date: Tue, 7 May 2024 13:44:01 +0200 Subject: [PATCH] Remove obsolete comment Co-authored-by: Marco A. Gutierrez Signed-off-by: Mikael Arguedas --- sros2/sros2/_utilities.py | 3 --- .../test/sros2/commands/security/verbs/test_create_enclave.py | 3 --- 2 files changed, 6 deletions(-) diff --git a/sros2/sros2/_utilities.py b/sros2/sros2/_utilities.py index dc998e01..1a33c2bf 100644 --- a/sros2/sros2/_utilities.py +++ b/sros2/sros2/_utilities.py @@ -92,9 +92,6 @@ def build_key_and_cert(subject_name, *, ca=False, ca_key=None, issuer_name=''): ).serial_number( x509.random_serial_number() ).not_valid_before( - # Using a day earlier here to prevent Connext (5.3.1) from complaining - # when extracting it from the permissions file and thinking it's in the future - # https://github.com/ros2/ci/pull/436#issuecomment-624874296 utcnow ).not_valid_after( # TODO: This should not be hard-coded diff --git a/sros2/test/sros2/commands/security/verbs/test_create_enclave.py b/sros2/test/sros2/commands/security/verbs/test_create_enclave.py index 4bf865d3..28045039 100644 --- a/sros2/test/sros2/commands/security/verbs/test_create_enclave.py +++ b/sros2/test/sros2/commands/security/verbs/test_create_enclave.py @@ -125,9 +125,6 @@ def test_cert_pem(enclave_keys_dir): # Verify the cert is valid for the expected timespan utcnow = datetime.datetime.now(datetime.UTC) - # Using a day earlier here to prevent Connext (5.3.1) from complaining - # when extracting it from the permissions file and thinking it's in the future - # https://github.com/ros2/ci/pull/436#issuecomment-624874296 # TODO replace "not_valid_before"/"not_valid_after" functions by # "not_valid_before_utc"/"not_valid_after_utc" # once cryptography 42 is supported on all target platforms