-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permission validity should be configurable #186
Comments
That sounds like a bug, and could be fixed after feature freeze.
Yeah, that's more of a feature. |
@kyrofa @mikaelarguedas are you planning to land said feature for Foxy? |
It's after feature freeze now, so I suspect we'll go the bugfix route on this one. |
I don't know what this needs to be merged but we haven't frozen yet. It might still be ~ a day out. |
I won't work on this in the next couple days. I should be able to provide a bugfix to have matching validity dates next week |
bugfix submitted at #205 |
Feature request
Feature description
Generated permissions file should use the same validity period as the certificates.
Currently they use hard coded timeframe that expires in 2023
sros2/sros2/sros2/policy/templates/dds/permissions.xsl
Line 12 in 9e1d105
Implementation considerations
Certificates currently use [UTC:UTC+10years]
sros2/sros2/sros2/api/__init__.py
Line 451 in 9e1d105
The same could be used.
Ideally the user would be able to specify the start date and the dureation. That range would be applied to both the certificates and permissions files
The text was updated successfully, but these errors were encountered: