Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics: Highlight supported broadcasts #427

Open
davidak opened this issue Nov 27, 2017 · 12 comments
Open

Statistics: Highlight supported broadcasts #427

davidak opened this issue Nov 27, 2017 · 12 comments

Comments

@davidak
Copy link

davidak commented Nov 27, 2017

  • I'm submitting a ...

    • user interface improvement
  • What is the current behavior?
    A plain table. I cannot see which broadcasts I support already.

  • What is the expected behavior?
    If I support a broadcast it should be highlighted.

  • What is the motivation / use case for changing the behavior?
    If I click through the statistics, maybe I recognize a broadcast by title and I want to support it immediately. Avoid a context switch.

Something like this:
screenshot from 2017-11-27 14 13 46

@roschaefer roschaefer changed the title highlight broadcasts on statistic page that the user supports Statistics: Highlight supported broadcasts on statistic page Nov 27, 2017
@roschaefer roschaefer changed the title Statistics: Highlight supported broadcasts on statistic page Statistics: Highlight supported broadcasts Nov 27, 2017
@roschaefer
Copy link
Owner

Thank you @davidak for submitting this issue. I updated the description, is this what you want?

@roschaefer
Copy link
Owner

Being able to support a broadcast immediately would be nice, but there is a small problem: We track if a user as "seen" a broadcast, i.e. we save an "impression" in the database. This way we can compare how many people have seen the broadcast and did not click on "support". It is necessary to overcome unfair biases - a brand new broadcast has 0 supporters, but that's not because it's unpopular. It's because it was just added to the database.

So, we will probably not add a support button if the description is not visible (which is the case on the statistic page), but we can make the title of the broadcast a link to the broadcast page. A user can click on the title, visit the broadcast page broadcast/4711 and click support. That is a context switch. But at least you have a link on the statistics page, you see the description and the system can save an impression.

@davidak
Copy link
Author

davidak commented Nov 27, 2017

Yes, but with "highlight" i mean that the row should have a different background, like green or a darker one. But might not be necesarry.

@roschaefer
Copy link
Owner

Maybe a heart icon is unambiguous? A heart or a thumbs up icon means sth. like "I like that" whereas a green background means "good".

If there is enough space, we could also add the respective amount of the supported broadcast in green next to the total amount.

E.g.

164.56€ (+0.40€)

@davidak
Copy link
Author

davidak commented Nov 27, 2017

Since i thought about it longer i wouldn't color the rows. It's too much color. The heart would be enough to stand out. But when there are technical limitations, making the title a link to the detail page is also a good solution.

@roschaefer
Copy link
Owner

I would say, let's do both. I'm already creating a PR with links to the broadcast pages...

@davidak
Copy link
Author

davidak commented Nov 27, 2017

Adding your personal contribution to the amount is also very good. That might be enough to highlight broadcasts a user supports. Also a button to edit the amount, maybe a gear sign?

@roschaefer
Copy link
Owner

If you never visited "my broadcasts", the amount is nil. So a heart icon indicating support plus the amount would do.

@davidak
Copy link
Author

davidak commented Nov 27, 2017

Right, do it! :)

@roschaefer
Copy link
Owner

Editing the amount is a bit tricky, too. The system distributes your budget evenly. So you should edit the amount on a page where you can see all your amounts. E.g. If you fixed an amount to 10€ of one broadcast, you cannot give another broadcast 8€, that would be 10€+8€ = 18€ > 17.50. The statistic table is too large to see all your amounts at once.

@davidak
Copy link
Author

davidak commented Nov 27, 2017

What i mean is adding a gear icon that is a link to "my broadcasts". Maybe automatically select the text field of that broadcasts amount.

@roschaefer
Copy link
Owner

Oh, yep, that would be great. If you click on (+0.40€) you get to the "My broadcasts" page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants