Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly mark types for backward pass of VJP #99

Open
samestep opened this issue Sep 17, 2023 · 0 comments
Open

Correctly mark types for backward pass of VJP #99

samestep opened this issue Sep 17, 2023 · 0 comments

Comments

@samestep
Copy link
Contributor

As shown in the Hessian example added in #98, currently the VJP function type expects the backward pass input to be symbolic and says it may not return a fully symbolic value; this is flipped from what it should be. We should make these types more precise in the signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant