Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination to Watcher withdrawal token select #10

Open
2 tasks
mkermani144 opened this issue Jul 22, 2024 · 0 comments
Open
2 tasks

Add pagination to Watcher withdrawal token select #10

mkermani144 opened this issue Jul 22, 2024 · 0 comments
Labels
500 RSN Bounty contribution friendly Contributions outside Rosen Team are welcomed

Comments

@mkermani144
Copy link
Member

Description

Based on the /address/assets API implementation of watcher service, it can be seen that the API is paginated, defaulting to 20 items per page. In withdraw action of Watcher app, this pagination isn't respected at all, and it's supposed that it returns all of the address assets (which is wrong).

Acceptance conditions

  • The API should be called continuously, until all of the tokens are fetched
  • Same as the current implementation, SWR should be used for data fetching
@mkermani144 mkermani144 added contribution friendly Contributions outside Rosen Team are welcomed 500 RSN Bounty labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
500 RSN Bounty contribution friendly Contributions outside Rosen Team are welcomed
Projects
None yet
Development

No branches or pull requests

1 participant