Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README setup instructions are confusing #44

Open
chcorbato opened this issue Aug 6, 2020 · 7 comments
Open

README setup instructions are confusing #44

chcorbato opened this issue Aug 6, 2020 · 7 comments
Assignees

Comments

@chcorbato
Copy link
Member

Because there are two sections: "Setup using wstool" and "Manually setup", I though I could simply follow one of them, so I did with wstool.
But you actually need to do BOTH.

I propose to have a single "Installation and setup section", and introduce both sets of instructions with a sentence in normal text, not as a header.

@marioney
Copy link
Member

marioney commented Aug 6, 2020

But you actually need to do BOTH.

Then there's something missing on the wstool because it should already install everything.

Do you remember what was missing from the wstool?

@chcorbato
Copy link
Member Author

chcorbato commented Aug 6, 2020

Do you remember what was missing from the wstool?

Based on the errors I got, that I fixed installing the following with apt:

  • map_server
  • fake_localization
  • laser_filters

I was going carzy because I thought I had already posted this in a issue, now I see you already saw it :-D

@chcorbato
Copy link
Member Author

Bring here the discussion about the Set Up instructions:
rosin-project/metacontrol_experiments#14

@marioney
Copy link
Member

marioney commented Aug 6, 2020

I've removed the Manual setup section in 53c5ae2, I should work now with the wstools.

@darkobozhinoski
Copy link

darkobozhinoski commented Aug 7, 2020

Do you remember what was missing from the wstool?

Based on the errors I got, that I fixed installing the following with apt:

  • map_server
  • fake_localization
  • laser_filters

I was going carzy because I thought I had already posted this in a issue, now I see you already saw it :-D

@marioney This is still an issue. I needed to install these packages manually.

@rosin-project rosin-project deleted a comment from darkobozhinoski Aug 7, 2020
@marioney
Copy link
Member

marioney commented Aug 7, 2020

@marioney This is still an issue. I needed to install these packages manually.

I see now https://github.com/rosin-project/metacontrol_experiments is not in the metacontrol_sim.rosinstall file. I think I added the dependencies in the wrong repo, they should be here.

@marioney
Copy link
Member

marioney commented Aug 7, 2020

OK, I've added the dependencies to this repo in 08f8c5c

rosdep should install everything now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants