Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isXML() may need to add more conditions #34

Open
gitfish256 opened this issue Oct 5, 2017 · 1 comment
Open

isXML() may need to add more conditions #34

gitfish256 opened this issue Oct 5, 2017 · 1 comment

Comments

@gitfish256
Copy link

Hi,

Thanks for the nice plugin, the copy xpath at cursor is really useful. When I used this plugin on some xml files which extension is not .xml, it won't return anything. Is it necessary to add isXML() before do the copy? I removed this and tried this with several other text format(e.g., .txt, .csv), other than producing wrong result it looks good, and I got correct result if the content is in xml format. So is it ok to let user decide whether the output is legit rather than do it inside the plugin? Thank you!

@keith-hall
Copy link
Collaborator

if you upgrade to Sublime Text 3, you'll see that this plugin will work for any files using XML (or HTML) syntax highlighting, regardless of whether the file has been saved with an XML extension or not. If you are determined to stick with ST2, we may accept Pull Requests to the old ST2 branch if you want to improve the isXML method yourself, but I'm personally only committed to maintaining the ST3 version of this xpath plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants