Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add constraints for port connectors #5

Open
7 of 9 tasks
minhnh opened this issue Apr 16, 2020 · 8 comments · Fixed by #9, #7, #8 or #19
Open
7 of 9 tasks

add constraints for port connectors #5

minhnh opened this issue Apr 16, 2020 · 8 comments · Fixed by #9, #7, #8 or #19
Assignees
Labels
enhancement New feature or request

Comments

@minhnh
Copy link
Member

minhnh commented Apr 16, 2020

  • No connection across containers' boundaries allowed, i.e. ports of a block can only be connected to ports of its "siblings" (blocks which have the same container) or ports of its container (scoping)
  • A connection between 2 ports should not be repeated (checking rule)
  • A DataConnector or TriggerConnector should not connect a port to itself (checking rule)
  • A connector cannot connect ports of the same block (checking rule)
  • port direction constraint for ports of parent block vs sibling blocks (checking rule)
  • ports of the same block should have unique names (checking rule)
  • there should be no unconnected port (checking rule)
  • constraints on whether a data connection should be allowed:
data connection to FunctionBlock DataBlock SchedulerBlock
"sibling" FunctionBlock n y n (?)
"sibling" DataBlock y ? y (?)
"sibling" SchedulerBlock n (?) y (?) n (?)
containing FunctionBlockContainer y y y (?)
containing DataBlockContainer - y -
  • constraints on whether a trigger connection should be allowed
trigger connection to FunctionBlock SchedulerBlock
"sibling" FunctionBlock ? y (?)
"sibling" SchedulerBlock y (?) y (?)
containing FunctionBlockContainer y y
@minhnh
Copy link
Member Author

minhnh commented Apr 20, 2020

  • DataConnector or TriggerConnector shouldn't connect ports which both have In or Out direction

@svenschneider
Copy link
Contributor

All those constraints apply for the trigger connections, too.

@svenschneider
Copy link
Contributor

We should enforce a unique name/identifier policy on the ports in the same block.

@scymtym
Copy link
Contributor

scymtym commented Apr 20, 2020

Can we take some of the necessary constraints from the NPC 4 paper like Herman suggested?

@svenschneider
Copy link
Contributor

Of course! It would be nice if we were able to "reuse" the constraints in other BPC-compliant metamodels (e.g. by M2M transformations).

@rosym-project rosym-project deleted a comment from svenschneider Apr 20, 2020
@minhnh
Copy link
Member Author

minhnh commented Apr 20, 2020

@scymtym could you link to the NPC 4 paper here as well for reference?

@minhnh minhnh changed the title add constraints for DataConnector add constraints for port connectors Apr 20, 2020
@scymtym
Copy link
Contributor

scymtym commented Apr 20, 2020

@scymtym could you link to the NPC 4 paper here as well for reference?

The paper can be found here: https://core.ac.uk/display/45288978

@minhnh
Copy link
Member Author

minhnh commented Apr 24, 2020

I will reopen this issue with for constraints on which data connection to be allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment