Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio stream muted after going to speak view and back to listen #59

Open
hburgund opened this issue Mar 21, 2017 · 2 comments
Open

audio stream muted after going to speak view and back to listen #59

hburgund opened this issue Mar 21, 2017 · 2 comments
Assignees

Comments

@hburgund
Copy link
Member

On several occasions while testing, I experienced a state where I could not hear any audio through the app, though I could see that audio was being generated on the server and that the various PATCH and POST requests to the streams/ endpoint were being acted upon on the server.

I can get this to happen by entering the speak view and then going back to listen. There may be other ways to force this odd state, but this one seems to work and is obviously a common use-case.

@hburgund hburgund self-assigned this Mar 22, 2017
@hburgund
Copy link
Member Author

It is possible if we move the place where the media player is instantiated to the Listen view per #56, this will be fixed or at least changed as well.

Unfortunately, I have done a lot more testing and the results are inconsistent. Sometimes this muted state happens and other times it does not and I can't figure out what causes the difference. The times when no audio is heard, the "Loading Stream" spinner doesn't appear, which I guess is not surprising.

Sometimes, if I re-select the Exhibition, and then try to play again, it will start playing again, but this too isn't consistent.

We should probably wait until #56 is fixed to see if that has any effect on this and then see if some consistencies can be uncovered.

@seeReadCode
Copy link
Collaborator

Does it have to do with:

  • whether the player was paused before moving to speak?
  • whether a spoken asset was recorded and uploaded?
  • whether the contribute flow was canceled?

When the room view disappears this runs:
https://github.com/seeRead/roundware-ios-digita11y/blob/master/Digita11y/RoomsViewController.swift#L292

If you see Map or Text first, the lock on keeping audio playing might not get reset to false before you move to Contribute. So that's a separate bug but related.
https://github.com/seeRead/roundware-ios-digita11y/blob/master/Digita11y/RoomsViewController.swift#L204-L213

Within viewAppear, we could a check for that lock, if it's true, reset it to false, else run startPlaying()

https://github.com/seeRead/roundware-ios-digita11y/blob/master/Digita11y/RoomsViewController.swift#L301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants