Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import PAC #1

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Import PAC #1

merged 2 commits into from
Aug 18, 2024

Conversation

thejpster
Copy link
Member

Brings over https://github.com/thejpster/rp-hal-rp2350-public/tree/main/rp235x-pac, but with changes so that the manual adjustments to lib.rs are no longer required. Instead I build two PACs and merge them using a custom lib.rs file which does #[cfg] and #[path] shenanigans.

Copy link
Member

@ithinuel ithinuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me although, I think we should squash the commits together.

Edit: I dont’s seem to have permissions to enable squash merges (to even access the settings actually).

I let svd2rust build both the Cortex-M and RISC-V versions of the PAC, and then
join them together in a custom lib.rs file.

Note that, GHA and Debian disagree about sorting so I re-sorted the files in an Ubuntu 20.04 container.
@thejpster thejpster added this pull request to the merge queue Aug 18, 2024
Merged via the queue into main with commit d581b9d Aug 18, 2024
12 checks passed
@ithinuel ithinuel deleted the import-pac branch August 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants