Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previousRow function is needed #37

Open
mindgitrwx opened this issue Jun 21, 2018 · 1 comment
Open

previousRow function is needed #37

mindgitrwx opened this issue Jun 21, 2018 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mindgitrwx
Copy link

First of all, thank you for having made this great extension.

I'm mapping this table generator with vscode's vim plugin, and I tried to map moving cell with h, j, k, l.

It seems not natural to exist nextRow function without previousRow function, ecpecially in this mapping. h, j, l key had been sucessfuly mapped with this extension, but k is not working well.

I checked this extension carefully, and I find there is no previousRow function.

Could you add this function for user experience?

@rpeshkov
Copy link
Owner

Hi @mindgitrwx,

There's now previousRow function mostly because it's quite useless. Going up 1 line will be mostly the same as previousRow. NextRow function exists mainly because when cursor is on the last row, new row will be inserted and that's not good case for previousRow since usually there's not so much use cases for adding new row in the top of table.

I'm not telling that I'm against that functionality, but for me that's definitely low priority. If you wish, you may create PR for that function. I'll gladly accept it to the codebase.

@rpeshkov rpeshkov added enhancement New feature or request good first issue Good for newcomers labels Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants