Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting with suggestions #54

Open
NeoFantom opened this issue Sep 8, 2019 · 3 comments
Open

Conflicting with suggestions #54

NeoFantom opened this issue Sep 8, 2019 · 3 comments

Comments

@NeoFantom
Copy link

Sometimes I need to use word suggestions provided by vscode. But I have to commit the suggested word with tab or enter. Problem is: when I'm in table mode, both tab and enter has cell-ralated functions which overrides the default suggestion-commiting. How to make this work for me?
Below is a gif of what happens after I press enter:
cannotCommitSuggestion

@rpeshkov
Copy link
Owner

rpeshkov commented Sep 8, 2019

Hi @NeoFantom,

You could try to remap keys a bit.

{ "key": "tab", "command": "-text-tables.gotoNextCell", "when": "tableMode" },
{ "key": "tab", "command": "text-tables.gotoNextCell", "when": "tableMode && !suggestWidgetVisible" },
{ "key": "enter", "command": "-text-tables.nextRow", "when": "tableMode" },
{ "key": "enter", "command": "text-tables.nextRow", "when": "tableMode && !suggestWidgetVisible" }

These lines remove Tab and Enter bindings that extension brings and map them back with additional when clause. After you apply this settings in your keybindings file, Tab and Enter will have default behavior when suggestions list is visible.

@NeoFantom
Copy link
Author

Perfect solution! Can't stress enough how grateful I am!

@rpeshkov
Copy link
Owner

rpeshkov commented Sep 9, 2019

Glad that it helped you. I guess I will make changes into keybinding of extension so that this behavior will be default.

philipparndt added a commit to philipparndt/vscode-text-tables that referenced this issue Nov 22, 2020
philipparndt added a commit to philipparndt/vscode-text-tables that referenced this issue Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants