You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the code of Subproblem 2, for single-solution case, order of the parameters to subproblem 1 is wrong.
This is the test to verify the issue:
# subproblem2 another testa3_2=rox.subproblem2(z, x, x, y) # Passes (apparently by luck)a3_22=rox.subproblem2([0, 0, 0.01851852], [0.01851852, 0, 0], x, y) # This gives the error below"""Traceback (most recent call last):File "<stdin>", line 1, in <module>File "/home/burak/.local/lib/python3.8/site-packages/general_robotics_toolbox/general_robotics_toolbox.py", line 766, in subproblem2 # theta1 = -subproblem1(k1, q, c1)File "/home/burak/.local/lib/python3.8/site-packages/general_robotics_toolbox/general_robotics_toolbox.py", line 706, in subproblem1 theta = subproblem0(epp, eqp, k)File "/home/burak/.local/lib/python3.8/site-packages/general_robotics_toolbox/general_robotics_toolbox.py", line 660, in subproblem0 assert (np.dot(k,p) < eps) and (np.dot(k,q) < eps), \AssertionError: k must be perpendicular to p and q"""assertlen(a3_2) ==1assertlen(a3_22) ==1a3_2_check= [(0.0, 1.5707963267948966)]
np.testing.assert_allclose(a3_2, a3_2_check, atol=1e-4)
np.testing.assert_allclose(a3_22, a3_2_check, atol=1e-4)
The text was updated successfully, but these errors were encountered:
In the code of Subproblem 2, for single-solution case, order of the parameters to subproblem 1 is wrong.
This is the test to verify the issue:
The text was updated successfully, but these errors were encountered: