Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Lowercase branches when constructing an image identifier
Executing a pull request test from a branch with upper case letters ended up with this error: Command '/var/ARTIFACTS/work-behave-createrepo_crye9wxe5/plans/integration/behave-createrepo_c/tree/tmt-prepare-wrapper.sh-Build-testing-container-default-0' returned 1. stderr (2 lines) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Error: tag container-test-unistd-for-STDOUT_FILENO-master: invalid reference format: repository name must be lowercase Error: Failed to build the container. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The cause was that -c argument of container-test script was built from a "container-test-unistd-for-STDOUT_FILENO" branch name. The container-test -c value is then directly passed as an image identifier to podman build and podman run commands. Problem is that podman, as well as docker, does not allow upper-case characters in the OCI identifier. I wanted to circumvent it in the container-test script, to have a fix at one place. But one can pass a tag name there (foo/bar:tag) and the tag is handled case sensitively by docker. So this patch fixes it on the invocation side. NOTE: I could not really test it. I only tried a prepare phase of locally run TMT and it correctly transliterated the branch names. You should be able to fix by rerunning tests for <rpm-software-management/createrepo_c#439>.
- Loading branch information