Enable tests for module info that don't require install #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like 2 tests are still expecting the output in different order. |
pkratoch
force-pushed
the
enable-module-tests
branch
from
277bb33 to
0138bd7
Compare
Yes sorry, I implemented the sorting now: rpm-software-management/dnf5#1109 |
I considered installing modules using dnf4 and enabling the `info.feature`, but dnf5 then doesn't have information about how that changed the module states, since it's stored differently in dnf4 and dnf5, so it's not very usable. Instead, I created a duplicit set of tests for module info without the need of module install. They can be removed once the install command is implemented and the `info.feature` enabled.
pkratoch
force-pushed
the
enable-module-tests
branch
from
0138bd7 to
83141a2
Compare
jan-kolarik
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered installing modules using dnf4 and enabling the
info.feature, but dnf5 then doesn't have information about how that changed the module states, since it's stored differently in dnf4 and dnf5, so it's not very usable.Instead, I created a duplicit set of tests for module info without the need of module install. They can be removed once the install command is implemented and the
info.featureenabled.The order of module streams listed is different, because it's not sorted (at least yet), but the output of dnf4 also doesn't seem sorted.
Requires: rpm-software-management/dnf5#1093
Requires: rpm-software-management/dnf5#1094
Requires: rpm-software-management/dnf5#1098