Add test for remove command to ensure not removing according to provides #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisar
reviewed
Jan 5, 2024
ppisar
reviewed
Jan 5, 2024
dnf-behave-tests/fixtures/specs/dnf-ci-provides-alternatives/bar-1.0.spec
Outdated
Show resolved
Hide resolved
ppisar
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Could you link the related DNF5 change rpm-software-management/dnf5#1126 from this commit message?
j-mracek
force-pushed
the
remove-no-provides
branch
2 times, most recently
from
ac95813 to
126f464
Compare
|
@ppisar I think I've fixed it |
ppisar
reviewed
Jan 8, 2024
ppisar
reviewed
Jan 8, 2024
The new behavior is more stable for cases when the same spec is used multiple times with remove command. Requires: rpm-software-management/dnf5#1126
j-mracek
force-pushed
the
remove-no-provides
branch
from
126f464 to
183789f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new behavior is more stable for cases when the same spec is used multiple times with remove command.