Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Recommends to simulate real debuginfo pkgs #1550

Merged

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Sep 17, 2024

Since rpm-4.19.94-1.fc42 the rpm debuginfo code logic is not always executed. To match real debuginfo pkgs add debugsource recommends manually.

More details: rpm-software-management/rpm#3310

@pkratoch pkratoch self-assigned this Sep 18, 2024
@pkratoch
Copy link
Contributor

Thanks! I am just thinking, shouldn't it be added also to other debuginfo packages, as it's something that rpm would do if these were real debuginfo packages? Also, dnf4 is not in Fedora rawhide, but the affected rpm version might get into RHEL or other Fedora releases, so we should perhaps make this change also for dnf-4-stack.

Since `rpm-4.19.94-1.fc42` the rpm debuginfo code logic is not always
executed. To match real debuginfo pkgs add debugsource recommends
manually.

More details: rpm-software-management/rpm#3310
@kontura kontura force-pushed the debuginfo-debugsource branch from a2d2e44 to 65d63df Compare September 18, 2024 13:33
@kontura
Copy link
Contributor Author

kontura commented Sep 18, 2024

Thanks! I am just thinking, shouldn't it be added also to other debuginfo packages, as it's something that rpm would do if these were real debuginfo packages?

Ok, I have added it to other debuginfo - debugsource pairs in the debuginfo-install repo. I have checked and there are two additional pairs in dnf-ci-fedora-updates (lz4 and zstd) but those already have the recommends.

Also, dnf4 is not in Fedora rawhide, but the affected rpm version might get into RHEL or other Fedora releases, so we should perhaps make this change also for dnf-4-stack.

That is a good suggestion I will backport the changes to dnf-4-stack branch. 👍

@pkratoch pkratoch merged commit 73a8437 into rpm-software-management:main Sep 18, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants