Skip to content

Commit

Permalink
Remove custom CMake modules, use pkg-config instead
Browse files Browse the repository at this point in the history
The custom CMake modules don't add any value, just failure potential.
Get rid of the glue and use standard pkg-config instead.
  • Loading branch information
Lukáš Hrázký authored and Conan-Kudo committed Feb 16, 2021
1 parent b78d47d commit d1f70b1
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 460 deletions.
24 changes: 15 additions & 9 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,22 @@ SET(G_LOG_DOMAIN "C_CREATEREPOLIB")

find_package(BZip2 REQUIRED)
find_package(CURL REQUIRED)
find_package(GLIB2 REQUIRED)
find_package(GTHREAD2 REQUIRED)
find_package(Libmagic REQUIRED)
find_package(LibXml2 REQUIRED)
find_package(LZMA REQUIRED)
find_package(OpenSSL REQUIRED)
find_package(Sqlite3 REQUIRED)
find_package(ZLIB REQUIRED)

pkg_check_modules(GLIB2 REQUIRED glib-2.0)
pkg_check_modules(GTHREAD2 REQUIRED gthread-2.0)
pkg_check_modules(LZMA REQUIRED liblzma)
pkg_check_modules(SQLITE3 REQUIRED sqlite3)

pkg_check_modules(LIBMAGIC libmagic)
# the pkg-config was only added in F33
IF (NOT LIBMAGIC_FOUND)
find_path(LIBMAGIC_INCLUDE_DIRS NAMES magic.h PATHS ${CMAKE_INCLUDE_PATH})
find_library(LIBMAGIC_LIBRARIES NAMES magic PATHS ${CMAKE_LIBRARY_PATH})
ENDIF()

# Add include dirs

include_directories(${BZIP2_INCLUDE_DIRS})
Expand All @@ -53,7 +60,6 @@ include_directories(${LIBXML2_INCLUDE_DIR})
include_directories(${OPENSSL_INCLUDE_DIR})
include_directories(${ZLIB_INCLUDE_DIR})


IF (RPM_PATH)
SET (RPM_PATH "/home/tmlcoch/git/rpm")
include_directories("${RPM_PATH}/include/")
Expand Down Expand Up @@ -109,9 +115,9 @@ ENDIF (WITH_ZCHUNK)

OPTION (WITH_LIBMODULEMD "Build with libmodulemd support" ON)
IF (WITH_LIBMODULEMD)
find_package(LIBMODULEMD REQUIRED)
include_directories(${LIBMODULEMD_INCLUDE_DIRS})
SET (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DWITH_LIBMODULEMD")
pkg_check_modules(LIBMODULEMD REQUIRED modulemd-2.0)
include_directories(${LIBMODULEMD_INCLUDE_DIRS})
SET (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DWITH_LIBMODULEMD")
SET (CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} -DWITH_LIBMODULEMD")
ENDIF (WITH_LIBMODULEMD)

Expand Down
100 changes: 0 additions & 100 deletions cmake/Modules/FindGLIB2.cmake

This file was deleted.

78 changes: 0 additions & 78 deletions cmake/Modules/FindGTHREAD2.cmake

This file was deleted.

40 changes: 0 additions & 40 deletions cmake/Modules/FindLIBMODULEMD.cmake

This file was deleted.

52 changes: 0 additions & 52 deletions cmake/Modules/FindLZMA.cmake

This file was deleted.

25 changes: 0 additions & 25 deletions cmake/Modules/FindLibmagic.cmake

This file was deleted.

Loading

0 comments on commit d1f70b1

Please sign in to comment.