Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use : character in username #1556

Closed
jrohel opened this issue Jun 24, 2024 · 2 comments · Fixed by #1560
Closed

Cannot use : character in username #1556

jrohel opened this issue Jun 24, 2024 · 2 comments · Fixed by #1560
Assignees
Labels
RFE Request For Enhancement (as opposed to a bug) Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take

Comments

@jrohel
Copy link
Contributor

jrohel commented Jun 24, 2024

The same problem is in the old libdnf (affects DNF4, microdnf, PackageKit, ...). Because both projects use librepo.
Librepo uses libcurl. To set the username and password librepo uses the old libcurl API option CURLOPT_USERPWD.

Suggested fix:
Extend librepo API. The new librepo API will use the new libcurl API options CURLOPT_USERNAME and CURLOPT_PASSWORD.
Modify dnf5 to use the new librepo API.

@ppisar
Copy link
Contributor

ppisar commented Jun 24, 2024

Or you can enhance librepo to recognize "::" as literal ":", split on the single ":" and pass username and password to libcurl with separate calls.

@ppisar ppisar added RFE Request For Enhancement (as opposed to a bug) Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take labels Jun 24, 2024
@jrohel
Copy link
Contributor Author

jrohel commented Jun 24, 2024

Or you can enhance librepo to recognize "::" as literal ":", split on the single ":" and pass username and password to libcurl with separate calls.

LRO_USERPWD is not consistent with LRO_PROXYUSERPWD. And after the proposed modification, it would no longer be consistent with libcurl behavior either.

I prepared a PR rpm-software-management/librepo#316 and added LRO_USERNAME and LRO_PASSWORD following the libcurl approach.

@github-project-automation github-project-automation bot moved this from Backlog to Done in DNF team Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFE Request For Enhancement (as opposed to a bug) Triaged Someone on the DNF 5 team has read the issue and determined the next steps to take
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants