Upgrading obsoleted package with --best doesn't keep reason

[pkratoch]

If an obsoleted package is installed as a dependency, and it is then upgraded and therefore replaced with its obsoleter, the new package is marked as userinstalled.

This is a regression, in dnf4 there was a bug https://bugzilla.redhat.com/show_bug.cgi?id=1672618 which was fixed by rpm-software-management/libdnf#772 and rpm-software-management/dnf#1459 . However, I think it doesn't work even for dnf4 now. The tests for the bug were created before the bug was fixed and the one for --best was marked as xfail and never enabled after the bug was fixed: rpm-software-management/ci-dnf-stack@54a10ce

[kontura]

Recently I created a related CI test: rpm-software-management/ci-dnf-stack#1567
It is for a user installed obsoleted package.

[pkratoch]

Recently I created a related CI test: rpm-software-management/ci-dnf-stack#1567 It is for a user installed obsoleted package.

Great, that's basically the same, but with keeping reason "user" instead of "dependency". Plus having more obsoleters. And it doesn't behave differently for --best vs. --nobest. It might be also added to the two scenarios in the install-obsoletes.feature, so that they are all at the same place.

[kontura]

That is a good idea, I have moved the test to install-obsoletes.feature.