Always run Cython at build time #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10 was not actually running Cython as part of the
pyproject.tomlbuild; this PR fixes that. There is a knob to not run Cython and use the included C sources, but there is no way to have Cython be only installed optionally. It has to do with build environment isolation, which would be a bad thing to disable. If a compiler is missing the build should also not error. The C sources are no longer strictly necessary but I left them in and added the missing Becke one.This also runs CI on Windows, and MSVC does actually compile the extensions. I think my end goal would be to add https://github.com/pypa/cibuildwheel, but I didn't want to make this PR even bigger. Eventually you could use this to distribute compiled Windows wheels.