Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly track deferred syscall patching with the syscall event #3881

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Nov 15, 2024

  1. Properly track deferred syscall patching with the syscall event

    This fixes #3880 by moving the deferred syscall patching flag from
    Task to the corresponding syscall event. Both to avoid the assertion
    in that issue and for performance (since unpatched syscalls are traced),
    it is important that we (attempt to) patch the correct syscall ip.
    
    Additionally, we add the ability for tests to make sure that a particular
    syscall was actually patched. In particular, our logic for bailing out
    when another task is in the patch region was accidentally preventing
    all future attempts at patching the same region, even if doing so
    would have succeeded. With that fixed up, the new test will make sure
    this doesn't regress.
    Keno committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    384fcbc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1d56770 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Add missing synchronization edge

    Keno committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    822b80c View commit details
    Browse the repository at this point in the history