Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Refreshable instead of ProviderListenable from select and selectAsync #3875

Open
amevee opened this issue Dec 17, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@amevee
Copy link

amevee commented Dec 17, 2024

.select and .selectAsync should return Refreshable which should refresh underlying base provider (and then select will be reevaluated as usual) instead of returning ProviderListenable.

@rrousselGit
Copy link
Owner

What's the goal here? You're not listening to the provider anyway when using ref.refresh, so there's no difference between ref.refresh(p.select((v) => v.name)) and ref.refresh(p).name

@rrousselGit rrousselGit added question Further information is requested and removed needs triage labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants