Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of epsilon in models #127

Open
kmdalton opened this issue Aug 2, 2023 · 0 comments
Open

Inconsistent use of epsilon in models #127

kmdalton opened this issue Aug 2, 2023 · 0 comments

Comments

@kmdalton
Copy link
Member

kmdalton commented Aug 2, 2023

Many objects which extend BaseModel take a keyword eps= to signify the numerical precision of the model. I think this should be codified as a constructor argument for the BaseModel class which sets the self.eps attribute. This would make the concept consistent across the API. Classes should be refactored as needed to support this parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant