Skip to content

Commit

Permalink
kernel: make 'no port node found' output a debug message
Browse files Browse the repository at this point in the history
There are cases where an unavailable port is not an error, making
this error message a false-positive. The kernel log is flooded with
the messages like:
  OF: graph: no port node found in /soc@0/bus@42000000/i2c@42530000/usb-typec@50

Silence this message by making it a debug message.

Signed-off-by: Tianling Shen <[email protected]>
Link: openwrt#16524
Signed-off-by: Hauke Mehrtens <[email protected]>
  • Loading branch information
1715173329 authored and hauke committed Sep 28, 2024
1 parent c9280b8 commit 17ea41e
Showing 1 changed file with 33 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
From e20cd62b1f1708a4dec7ff4beb9e748a0bdb5716 Mon Sep 17 00:00:00 2001
From: Alexander Stein <[email protected]>
Date: Wed, 17 Jan 2024 09:32:06 +0100
Subject: [PATCH] of: property: Make 'no port node found' output a debug
message

There are cases where an unavailable port is not an error, making this
error message a false-positive. Since commit d56de8c9a17d8 ("usb: typec:
tcpm: try to get role switch from tcpc fwnode") the role switch is tried
on the port dev first and tcpc fwnode afterwards. If using the latter
bindings getting from port dev fails every time. The kernel log is flooded
with the messages like:
OF: graph: no port node found in /soc@0/bus@42000000/i2c@42530000/usb-typec@50
Silence this message by making it a debug message.

Signed-off-by: Alexander Stein <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Rob Herring <[email protected]>
---
drivers/of/property.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/of/property.c
+++ b/drivers/of/property.c
@@ -664,7 +664,7 @@ struct device_node *of_graph_get_next_en
of_node_put(node);

if (!port) {
- pr_err("graph: no port node found in %pOF\n", parent);
+ pr_debug("graph: no port node found in %pOF\n", parent);
return NULL;
}
} else {

0 comments on commit 17ea41e

Please sign in to comment.