-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support latest prince version #59
Comments
That's not such easy, as the URLs for downloading are heavily depending on the current available operating systems and PrinceXML versions. As a workaround, you can always just install your favorite PrinceXML version somewhere in your system (just ensure the |
Thank you for responding. My suggestion is to make the version configurable. So that you can specify which version to download. When this is possible we can ask PrinceXML to create an npm package with version information which is create from their CI/CD script. This json file holds the current version and the latest version so that you can also configure current and latest. In this way you will recieve a pull request ccreated by dependabot as soon as there is a new release. |
If have asked Micheal Day (@adrianwong) to create an NPM package (which is linked to their release pipeline) with latest and current version information so that this project can link and consume this information.
|
Well, for determining the current version a version.json file could be just placed onto their website. There is no need to publish a whole NPM package. But the main issue is that one would need actually a file where all the particular binaries (with their platform/OS identifiers) is listed. That's the main issue. |
Then you do not have controlled upgrade via a pull request created automatically by dependabot, right?
Maybe I am wrong, but from what I can see, the file paths are created by convention where only the version changes. So only templating the urls with version will be sufficient.... @adrianwong can you elaborate on this? |
Hi, we've been looking at this and perhaps we can submit a pull request to refactor the if-then-else chain that determines (By the way Adrian Wong and I are separate people at YesLogic working on Prince). |
Hi,
Can you make the princeXml version configurable:
Thank you!
Arjan
The text was updated successfully, but these errors were encountered: