Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to 32 bytes chain work #25

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add support to 32 bytes chain work #25

wants to merge 23 commits into from

Conversation

nathanieliov
Copy link

These changes provide a long-term fix for the 12-byte bug that we had at btc block 849,138.

List of the changes done.

  • Added deserializeCompactV2 method to deserialize block with 32-byte chain work.
  • Added serializeCompactV2 method to serialize block with 32-byte chainwork
  • Deprecated CheckpointManager.readBinary method
  • Added read binary checkpoints unit tests
  • Added the use use of serializeCompactV2 for textual format in BuildCheckpoints
  • Added the use of deserializeCompactV2 to support 32 bytes chain work when reading textual checkpoints format
  • Added v2 format to LevelDBBlockStore

How Has This Been Tested?

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)

nathanieliov and others added 22 commits November 7, 2024 22:55
@nathanieliov
Add serializeCompactV2 method to serialize 32 byte chain work
914cd00
@nathanieliov
Add tests for serializeCompactV2
8d0138a
@nathanieliov
- Improve comments
989732a 
- Reorganize statics
- Remove unrelated tests
@nathanieliov
- Improve comments to understand key class variables meaning
742c51a 
- Rename serializeCompact to serializeCompactLegacy to avoid confusion
- Add deprecate tag to serializeCompactLegacy
- Remove unnecessary check of chainWorkBytes size
@nathanieliov
Add deserializeCompactV2 method to deserialize 32 byte chain work
698a660
@nathanieliov
Add tests for deserializeCompactV2
2c347fe
@nathanieliov
- Renamed deserializeCompact to deserializeCompactLegacy
f8e8e82 
- Deprecated deserializeCompactLegacy
@nathanieliov
- Update CheckpointManager description comment
b780f11 
- Deprecate CheckpointManager.readBinary  method
@nathanieliov
- Update readBinary method to throw an exception when processed malfo…
4c74080 
…rmed  checkpoints file

- Add read binary checkpoints unit tests
- Add testnet and mainnet binary sample file for unit tests
@nathanieliov
Fix issues after rebased
41a2764
@nathanieliov
- Add support to 32 bytes chain work to textual checkpoints format
3e6d064 
- Add tests for textual format reading
@nathanieliov
Fix format
f2cbe5b
@nathanieliov
Remove binary format support in BuildCheckpoints
9f7884a
@nathanieliov
Use serializeCompactV2 for textual format in BuildCheckpoints
ead7ec4
@nathanieliov
Add tests for BuildCheckpoints tool
135e445
@nathanieliov
- Renamed V1 format class variables
2434594 
- Refactored serializeCompactLegacy and serializeCompactV2 to get rid of duplicate logic
@nathanieliov
Add Level DB tests files created using legacy format
ff54196
@nathanieliov
add unit tests for LevelDBBlockStore testing legacy format
0b4f3d0
@nathanieliov
- add v2 format to LevelDBBlockStore
ad188de 
- add unit tests for LevelDBBlockStore testing v2 format
@nathanieliov
Fix issues after rebased
c7208d0
@nathanieliov
Moved test level db files to test/resources
fec443f
@marcos-iov
Merge pull request #24 from rsksmart/use-serializeCompactV2-at-LevelD…
bd807bc 
…BBlockStore

Add use of serialize/Deserialize compact v2 to LevleDbBlockStore
@nathanieliov nathanieliov changed the title 32 byte chainwork support integration Add support to 32 bytes chain work Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanieliov @marcos-iov