Feature/GBI-1840 - P2SH address support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added support to P2SH address, including a generic function (
outputScriptToAddress) that allows the consumer to parse an output script without knowing its specific type.PS: also added the library for the test-coverage reports
Why
Right now flyover supports P2PKH and P2SH addresses and this library was only allowing to parse P2PKH, also in the future we're looking to support all the types of addresses so the consumer should be able to call one function regardless of the type of the output script
Task
https://rsklabs.atlassian.net/browse/GBI-1840