Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAO-347: add date filters to transactions endpoint #141

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sleyter93
Copy link
Collaborator

We are moving to blockscout indexer to support these filters.

@sleyter93 sleyter93 self-assigned this May 3, 2024
@sleyter93 sleyter93 requested a review from Freshenext May 3, 2024 15:00
Copy link
Collaborator

@Freshenext Freshenext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, after that we should be good 💪💪💪💪

src/controller/httpsAPI.ts Outdated Show resolved Hide resolved
src/api/openapi.js Outdated Show resolved Hide resolved
src/blockscoutApi/index.ts Outdated Show resolved Hide resolved
src/controller/httpsAPI.ts Outdated Show resolved Hide resolved
src/repository/DataSource.ts Outdated Show resolved Hide resolved
@sleyter93 sleyter93 force-pushed the feature/dates branch 2 times, most recently from c1e9830 to 9c198e4 Compare May 9, 2024 04:14
@sleyter93 sleyter93 requested a review from Freshenext May 9, 2024 04:15
Copy link
Collaborator

@Freshenext Freshenext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🍰

@sleyter93 sleyter93 requested a review from jessgusclark May 10, 2024 14:41
Copy link
Member

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question.

.env Outdated
API_URL=https://rootstock-testnet.blockscout.com/api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, this is the testnet URL endpoint, does this PR also handle mainnet? Knowing that the Wallet App still needs to handle mainnet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants