Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review ReviewTransactionModal because we might have precision errors #71

Open
ilanolkies opened this issue Nov 30, 2021 · 0 comments
Open

Review ReviewTransactionModal because we might have precision errors #71

ilanolkies opened this issue Nov 30, 2021 · 0 comments

Comments

@ilanolkies
Copy link
Contributor

We need to use only BigNumber and string, never passing through Number. We need to check this is happening now

This means we need to review ReviewTransactionModal because we might be using numbers there too

Originally posted by @ilanolkies in #70 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilanolkies